Skip to content

chore: envoy client#4521

Merged
NathanFlurry merged 1 commit intomainfrom
03-27-chore_envoy_client
Apr 5, 2026
Merged

chore: envoy client#4521
NathanFlurry merged 1 commit intomainfrom
03-27-chore_envoy_client

Conversation

@NathanFlurry
Copy link
Copy Markdown
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@railway-app
Copy link
Copy Markdown

railway-app bot commented Mar 28, 2026

🚅 Deployed to the rivet-pr-4521 environment in rivet-frontend

Service Status Web Updated (UTC)
frontend-inspector ❌ Build Failed (View Logs) Web Apr 5, 2026 at 11:27 am
website ❌ Build Failed (View Logs) Web Apr 5, 2026 at 11:27 am
frontend-cloud ❌ Build Failed (View Logs) Web Apr 5, 2026 at 11:27 am
ladle ❌ Build Failed (View Logs) Web Apr 5, 2026 at 11:27 am
kitchen-sink ❌ Build Failed (View Logs) Web Apr 5, 2026 at 11:27 am
mcp-hub ✅ Success (View Logs) Web Mar 28, 2026 at 12:30 am

@claude
Copy link
Copy Markdown

claude bot commented Mar 28, 2026

PR Review: chore: envoy client\n\nBlocking issues before merge:\n\n1. Local link dependency for antiox in package.json hardcodes /home/nathan/antiox. This breaks CI. antiox must be published to npm or added as a workspace package first.\n\n2. destroyActor sends ActorIntentStop, identical to stopActor. The doc says it avoids hibernation but no ActorIntentDestroy exists. Either fix the intent or remove destroyActor from the public API.\n\n3. ToEnvoyTunnelMessage handler is a TODO comment. config.fetch and config.websocket in EnvoyConfig are never called. HTTP and WebSocket routing from the gateway are non-functional.\n\n4. todo.md is committed inside the SDK package. Per CLAUDE.md it belongs in .agent/todo/ or .agent/notes/.\n\nSignificant issues:\n\n5. commandIdx is hardcoded as 0n in sendActorIntent. If meaningful it is a bug; if not, remove it from the type.\n\n6. ACK_COMMANDS_INTERVAL_MS is 5 minutes with no initial send on connect. The server can wait up to 5 minutes for a command ack after reconnect. Consider sending ack immediately after ToEnvoyInit.\n\n7. The timestamp field in kv.ts should follow the project naming convention of ended_at, created_at, etc.\n\nMinor issues:\n\n8. log(ctx) in actor.ts creates a new child logger on every call, unlike connection.ts which caches it.\n9. uint8ArraysEqual in envoy/index.ts duplicates arraysEqual already exported from utils.ts.\n10. kvGet has an O(n^2) key lookup; a hex-keyed Map would fix this.\n11. ws: any in EnvoyConfig.websocket should be a typed interface.\n12. prepopulateActorNames metadata should be Record<string, unknown> not any.\n13. Several comments are not complete sentences per CLAUDE.md style.\n\nPositive aspects:\n\nThe split into focused task modules mirrors the Tokio-style task decomposition from the Rust side and is a large improvement. Correct adoption of antiox primitives replaces ad hoc Promise queues. KV lifecycle and event history with resend-on-reconnect are well designed. The stringify.ts helpers improve debug logging.

@MasterPtato MasterPtato force-pushed the 03-20-feat_pb_actors_v3 branch from 23cce47 to 949143d Compare March 28, 2026 01:59
@NathanFlurry NathanFlurry force-pushed the 03-27-chore_envoy_client branch from b99d8e5 to c461b02 Compare March 28, 2026 23:45
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4521 March 28, 2026 23:45 Destroyed
@NathanFlurry NathanFlurry force-pushed the 03-27-chore_envoy_client branch from c461b02 to f902085 Compare March 30, 2026 18:51
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4521 March 30, 2026 18:52 Destroyed
@MasterPtato MasterPtato force-pushed the 03-20-feat_pb_actors_v3 branch from 949143d to afb8d48 Compare March 30, 2026 19:40
@MasterPtato MasterPtato force-pushed the 03-27-chore_envoy_client branch from f902085 to 6e4a901 Compare March 30, 2026 19:43
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4521 March 30, 2026 19:43 Destroyed
@MasterPtato MasterPtato force-pushed the 03-20-feat_pb_actors_v3 branch from afb8d48 to d52568e Compare March 31, 2026 01:40
@MasterPtato MasterPtato force-pushed the 03-27-chore_envoy_client branch from 6e4a901 to 056dbbc Compare March 31, 2026 01:40
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4521 March 31, 2026 01:40 Destroyed
@MasterPtato MasterPtato mentioned this pull request Mar 31, 2026
11 tasks
@MasterPtato MasterPtato force-pushed the 03-27-chore_envoy_client branch from 056dbbc to ecb7a20 Compare March 31, 2026 22:24
@MasterPtato MasterPtato force-pushed the 03-20-feat_pb_actors_v3 branch from d52568e to fb6f723 Compare March 31, 2026 22:24
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4521 March 31, 2026 22:24 Destroyed
@MasterPtato MasterPtato mentioned this pull request Mar 31, 2026
11 tasks
@MasterPtato MasterPtato force-pushed the 03-27-chore_envoy_client branch from ecb7a20 to 58851a4 Compare April 1, 2026 02:11
@MasterPtato MasterPtato force-pushed the 03-20-feat_pb_actors_v3 branch from fb6f723 to 67b71f3 Compare April 1, 2026 02:11
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4521 April 1, 2026 02:11 Destroyed
@MasterPtato MasterPtato force-pushed the 03-20-feat_pb_actors_v3 branch from 67b71f3 to fddb429 Compare April 2, 2026 02:47
@MasterPtato MasterPtato force-pushed the 03-27-chore_envoy_client branch from 58851a4 to 68bbabd Compare April 2, 2026 02:47
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4521 April 2, 2026 02:47 Destroyed
@MasterPtato MasterPtato force-pushed the 03-20-feat_pb_actors_v3 branch from fddb429 to e4d920a Compare April 3, 2026 01:24
@MasterPtato MasterPtato force-pushed the 03-27-chore_envoy_client branch from 68bbabd to 5c9a464 Compare April 3, 2026 01:24
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4521 April 3, 2026 01:24 Destroyed
@NathanFlurry NathanFlurry mentioned this pull request Apr 4, 2026
11 tasks
@NathanFlurry NathanFlurry marked this pull request as ready for review April 5, 2026 10:58
Copy link
Copy Markdown
Member Author

NathanFlurry commented Apr 5, 2026

Merge activity

  • Apr 5, 11:11 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 5, 11:27 AM UTC: Graphite rebased this pull request as part of a merge.
  • Apr 5, 11:28 AM UTC: @NathanFlurry merged this pull request with Graphite.

@NathanFlurry NathanFlurry changed the base branch from 03-20-feat_pb_actors_v3 to graphite-base/4521 April 5, 2026 11:24
@NathanFlurry NathanFlurry changed the base branch from graphite-base/4521 to main April 5, 2026 11:25
@NathanFlurry NathanFlurry force-pushed the 03-27-chore_envoy_client branch from 5c9a464 to 7526490 Compare April 5, 2026 11:26
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4521 April 5, 2026 11:27 Destroyed
@NathanFlurry NathanFlurry merged commit 53da854 into main Apr 5, 2026
8 of 19 checks passed
@NathanFlurry NathanFlurry deleted the 03-27-chore_envoy_client branch April 5, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant